don't "corrupt" all iterators by reversing the list after adding the

2007-10-08  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtkfilesystemmodel.c (got_root_folder_cb),
	(get_children_get_folder_cb): don't "corrupt" all iterators by
	reversing the list after adding the items.  Reversing the list isn't
	needed anyway as the order of the items in the model does not matter.
	(Fixes #327243, comment 10).

svn path=/trunk/; revision=18891

diff --git a/ChangeLog b/ChangeLog
index 915323ceb4ade451e0f74206e7b870275a7be8b1..4fd62b3c24c3baf8ade9069e7c0767dec4802541 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2007-10-08  Kristian Rietveld  <kris@imendio.com>
+
+       * gtk/gtkfilesystemmodel.c (got_root_folder_cb),
+       (get_children_get_folder_cb): don't "corrupt" all iterators by
+       reversing the list after adding the items.  Reversing the list isn't
+       needed anyway as the order of the items in the model does not matter.
+       (Fixes #327243, comment 10).
+
 2007-10-08  Kristian Rietveld  <kris@imendio.com>
 
        Fix #482841, patch by Karl Tomlinson.

diff --git a/gtk/gtkfilesystemmodel.c b/gtk/gtkfilesystemmodel.c
index f6be38fc11243743df2be63282f43a6d1316dbdb..8d67165a2c3bf4448a66fa0a31757ba6d864ebec 100644 (file)
--- a/gtk/gtkfilesystemmodel.c
+++ b/gtk/gtkfilesystemmodel.c
@@ -664,8 +664,6 @@ got_root_folder_cb (GtkFileSystemHandle *handle,
     }
   g_slist_free (roots);
 
-  model->roots = (FileModelNode *) g_slist_reverse ((GSList *)model->roots);
-
 out:
   g_object_unref (model);
   g_object_unref (handle);
@@ -1577,8 +1575,6 @@ get_children_get_folder_cb (GtkFileSystemHandle *handle,
       g_slist_free (child_paths);
     }
 
-  data->node->children = (FileModelNode *)g_slist_reverse ((GSList *)data->node->children);
-
   g_signal_connect (data->node->folder, "deleted",
                    G_CALLBACK (deleted_callback), data->node);
   g_signal_connect (data->node->folder, "files-added",